Skip to content

[MINOR] Remove duplicate shade relocation #17841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Jan 15, 2026
+0 −5
Merged

[MINOR] Remove duplicate shade relocation #17841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packaging/hudi-presto-bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@
<pattern>org.objenesis.</pattern>
<shadedPattern>org.apache.hudi.org.objenesis.</shadedPattern>
</relocation>

<relocation>
<pattern>org.apache.parquet.avro.</pattern>
<shadedPattern>org.apache.hudi.org.apache.parquet.avro.</shadedPattern>
Copy link
Member

@voonhous voonhous Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated shade pattern is shading with a presto prefix. Not sure if the duplication is intentional such that it falls into the correct scope during shading.

Can you please help to confirm?

Copy link
Contributor Author

@majian1998 majian1998 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our build, presto.bundle.bootstrap.shade.prefix defaults to org.apache.hudi.. With that value, the two relocations for org.apache.parquet.avro.* are effectively identical:

  • org.apache.parquet.avro.* -> org.apache.hudi.org.apache.parquet.avro.*
  • org.apache.parquet.avro.* -> ${presto.bundle.bootstrap.shade.prefix}org.apache.parquet.avro.* (=> org.apache.hudi.org.apache.parquet.avro.*)

So keeping both does not change shading scope/behavior; it is redundant and potentially confusing. This PR removes the hard-coded duplicate and keeps the prefix-based relocation.

Copy link
Contributor

@danny0405 danny0405 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

</relocation>
<relocation>
<pattern>org.apache.avro.</pattern>
<shadedPattern>org.apache.hudi.org.apache.avro.</shadedPattern>
Expand Down
Loading