[MINOR] Remove duplicate shade relocation #17841
Open
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
voonhous
reviewed
Jan 13, 2026
|
|
||
| <relocation> | ||
| <pattern>org.apache.parquet.avro.</pattern> | ||
| <shadedPattern>org.apache.hudi.org.apache.parquet.avro.</shadedPattern> |
Member
There was a problem hiding this comment.
The duplicated shade pattern is shading with a presto prefix. Not sure if the duplication is intentional such that it falls into the correct scope during shading.
Can you please help to confirm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
hudi-presto-bundle had two Maven Shade relocation rules for the same pattern (org.apache.parquet.avro.*). This is redundant (same result with the default prefix) and can be confusing/order-dependent when the bootstrap prefix is changed by profiles.
Summary and Changelog
Simplify shading configuration by keeping a single relocation for org.apache.parquet.avro.*.
Removed the duplicated hard-coded relocation to org.apache.hudi.org.apache.parquet.avro.*
Kept the existing relocation using ${presto.bundle.bootstrap.shade.prefix}
Impact
NONE
Risk Level
low — build-time configuration cleanup only; no runtime logic changes.
Documentation Update
none
Contributor's checklist