-
Notifications
You must be signed in to change notification settings - Fork 44
chore(deps): update dependency deno to v2 #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR updates the Deno runtime dependency from v1.x to v2.x in the runtime compatibility testing workflow. The change is part of a dependency update managed by Renovate. What Changed
Impact AnalysisThe WorkOS SDK uses minimal Deno APIs that are stable across versions:
All of these APIs remain unchanged in Deno v2, making this upgrade low-risk. The compatibility test simply imports the SDK and verifies the Deno v2 Breaking Changes ReviewAccording to the release notes, Deno v2.0.0 includes:
None of these breaking changes affect the simple import test performed in this workflow. The SDK doesn't use Deno-specific CLI flags, experimental APIs, or features that were removed in v2. Minor IssueThere's a formatting inconsistency: the version changed from Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Setup as setup-deno@v2
participant Deno as Deno Runtime
participant Test as ecosystem-check.ts
participant SDK as WorkOS SDK
GHA->>Setup: Install Deno with version "2.x"
Setup->>Deno: Download and install Deno 2.x
Deno-->>Setup: Installation complete
Setup-->>GHA: Deno ready
GHA->>GHA: npm install
GHA->>GHA: npm run build
GHA->>Test: npm run check:runtimes
Test->>Deno: deno eval 'import SDK'
Deno->>SDK: Import lib/index.js
SDK->>Deno: Load module with Web Crypto APIs
Deno-->>SDK: APIs available
SDK-->>Test: Return WorkOS class
Test->>Test: Verify WorkOS.name exists
Test-->>GHA: Test passed ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| - uses: denoland/setup-deno@v2 | ||
| with: | ||
| deno-version: v1.x | ||
| deno-version: 2.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version specification format is inconsistent with the previous version. The old version used v1.x (with 'v' prefix), but this changes to 2.x (without 'v' prefix).
While the denoland/setup-deno action likely handles both formats, it would be more consistent to use v2.x to match the previous format. This ensures compatibility if the action's version parsing logic is strict about format consistency.
| deno-version: 2.x | |
| deno-version: v2.x |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/runtime-tests.yml
Line: 15:15
Comment:
The version specification format is inconsistent with the previous version. The old version used `v1.x` (with 'v' prefix), but this changes to `2.x` (without 'v' prefix).
While the `denoland/setup-deno` action likely handles both formats, it would be more consistent to use `v2.x` to match the previous format. This ensures compatibility if the action's version parsing logic is strict about format consistency.
```suggestion
deno-version: v2.x
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
This PR contains the following updates:
v1.x→2.xRelease Notes
denoland/deno (deno)
v2.6.5Compare Source
createImageBitmap(#31402)setResourceTimingBufferSize() (#31603)
trusted-signing-actiontoartifact-signing-action(#31849)(#31683)
DatabaseSyncgarbage collection invalidating associatedresources (#31737)
BrokenPipeerror inop_print(#31844)(#31829)
optionsparameter inDeno.errors.*constructors(#31510)
GPUCompilationInfo&GPUCompilationMessage(#31780)
(#31785)
v2.6.4Compare Source
--unstable-npm-lazy-caching(#31704)(#31734)
package.jsonwhendeno.jsononly in root(#31736)
v2.6.3Compare Source
(#31684)
v2.6.2Compare Source
importing each other (#31654)
(#31584)
sqlite:backupcompatibility (#31610)setImmediatewith a pending timer (#31643)don't fail on node-gyp if not present (#31619)
(#31653)
v2.6.1Compare Source
DatabaseSynccompatibility (#31515)(#31614)
v2.6.0Compare Source
Read more: http://deno.com/blog/v2.6
--for script arg indeno install -gandsupport installing multiple packages (#31292)
internal frames in stack traces (#31247)
check + compile output (#31194)
for (#31075)
ImageDataFloat16Arraysupport (#31394)BroadcastChannel(#30770)--lockfile-onlyflag (#31376)Deno.env.toObject()for partial env permission(#31267)
(#31224)
deno audit(#31106)--ignore-read(#31363)deno init --empty(#31516)--ignore-env=...(#31187)deno x(aliasdx) for conveniently running binaries frompackages (#31138)
@types/nodetype declarations out of the box (#31502)publish: falseindeno.json(#30852)(#31534)
@types/nodeis cached when already in resolution (#31235)--unstable-tsgo(#31416)(#31449)
json config (#31264)
setAllowUnknownNamedParametersoption (#31202)StatementSync.iterate()should resetis_iter_finishedflagon every call (#31361)
url.domainToASCIIreturns empty string for invalid domains(#31219)
crypto.Cipheriv(#31389)worker_threads(#31231)
actually meaningful (#31455)
DatabaseSync.aggregate()(#31461)DatabaseSync.function()and better error details(#31386)
dns.lookupService(#31310)process.setegid()(#31155)process.setgid()andprocess.setuid()(#31162)process:seteuid()(#31160)setImmediateAPI (#30328)FileHandle.readFile(#31462)flagoption onfs.readfileandfs.readfilesync(#31129)
StatementSyncmethods after connectionhas closed (#31331)
setAllowUnknownNamedParameterserror message (#31319)(#31311)
(#31297)
double counting (#31536)
npm (#31494)
organizeImportswithout resolving specifiers (#31230)(#31530)
statfsexport fromnode:fs/promises(#31528)(#31233)
(#31253)
familyinserver.address()(#31465)process.stdin.isTTYwritable (#31464)Timeout.prototype.refresh(#31436)implementation for
emitWarningin scope (#31263)is_elfpanic in sui (#31388)v2.5.6Compare Source
(#31131)
v2.5.5Compare Source
constraint (#31031)
(#30752)
(#31007)
deno auditsubcommand (#30966)githubusercontent.com (#30913)
dns.resolve6compatibility (#30974)fs.read/fs.readSyncandfs.write/fs.writeSynccompatibility(#31013)
path.matchesGlobcompatibility (#30976)Symbolinenvshould not ask for permission(#30965)
crypto.createHmac(#31025)kReinitializeHandlework for TLS wrap (#31079)fs.writeandfs.writeSync(#30999)with underscores (#31057)
-A(#31021)changing workspace config (#30998)
source.organizeImports(#31016)napi_callback_infoinCallbackInfo(#30983)(#30919)
(#31055)
Eventto be overwritten on bootstrap (#30971)(#31026)
v2.5.4Compare Source
deno cache (#30957)
fs.cpandfs.cpSynccompatibility (#30502)fs.statandfs.statSynccompatibility (#30866)node:zlib'sgunzip(#30865)smifromzlib.crc32op function (#30907)v2.5.3Compare Source
(#30894)
(#30895)
declarations (#30893)
--allow-all(#30763)and bundledDependencies (#30875)
--connectedto--tunneland better handleDENO_DEPLOY_TOKENenv variable (#30786)deno check(#30868)changed (#30877)
v2.5.2Compare Source
Uint8Arraybase64/hex methods (#30686)Promise<void>(#30820)fs.readFile,fs.readFileSyncassert encoding (#30830)fs.statfsSyncandfs.statfscompatibility (#30662)CipherivandDecipherivbase64 encoding (#30806).batand.cmddirectly on windows (#30818)v2.5.1Compare Source
Deno.HttpClientinWebSocket(#30692)Deno.HttpClient(#30700)Uint8Array<ArrayBuffer>(#30716)fchmodon windows (#30704)fs.globacceptsURLcwd (#30705)fs.close(#30720)fs.closecallback function (#30679)deno init --npmstopped working on mac (#30730)(#30744)
containing permissions at root (#30742)
v2.5.0Compare Source
Read more: http://deno.com/blog/v2.5
deno fmt .when providing no files andno config files discovered (#30623)
--watchand--env-file(#30197)
ChildProcess.stdout&ChildProcess.stderr(#30552)bundleDependenciesin npm dependencies (#30521)Deno.testAPI (#30504)setTimeoutandsetInterval(#29993)deno runwith no arguments prints list of available tasks (#30592)tcpBacklogarg toDeno.listen{Tls}andDeno.serve(#30541)(#30624)
(#30523)
lib.dom.d.ts and lib.webworker.d.ts (#30647)
crypto.hkdfSyncreturns wrong result for non-Uint8ArrayTypedArray inputs (#30463)
fs.existsandfs.existsSynccompatibility (#30507)fs.mkdtempandfs.mkdtempSynccompatibility (#30602)fs.path'makelongandresolvecompatibility (#30503)nullkeypair in tls connect (#30516)--experimental-*flags when spawning childprocess (#26351)
node_modulesfolders fordeno init --npm ...(#30492)is correct (#30546)
add,cache, and allinstallvariants, move scripts and deprecation warnings after the report (#30549)
(#30608)
Windows (#30535)
require("..")(#30524)ArrayBufferas a backing buffer type forResponse.bodyand
Response.bytes(#30435)ArrayBufferas a backing buffer type forTextEncoder.encode()(#30434)(#30490)
v2.4.4Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.