Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions packages/core/src/v3/zodSocket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ type MessageFromSocketSchema<
payload: z.input<GetSocketMessageSchema<TMessageCatalog, K>>;
};

type NormalizedMessage = {
type: string;
version?: string;
payload: Record<string, any>;
};

export type MessagesFromSocketCatalog<TMessageCatalog extends ZodSocketMessageCatalogSchema> = {
[K in keyof TMessageCatalog]: MessageFromSocketSchema<K, TMessageCatalog>;
}[keyof TMessageCatalog];
Expand Down Expand Up @@ -187,6 +193,28 @@ export class ZodSocketMessageHandler<TRPCCatalog extends ZodSocketMessageCatalog
};
}

private isObject(value: any): value is Record<string, any> {
return value !== null && typeof value === "object" && !Array.isArray(value);
}

private normalizeMessage(eventName: string, message: any): NormalizedMessage {
const hasValidPayload = "payload" in message && "version" in message && this.isObject(message.payload);

if (hasValidPayload) {
return {
type: eventName,
...message,
};
}

const { version, ...rest } = message;
return {
type: eventName,
version: version,
payload: rest,
};
}

public registerHandlers(emitter: EventEmitterLike, logger?: StructuredLogger) {
const log = logger ?? console;

Expand All @@ -206,14 +234,8 @@ export class ZodSocketMessageHandler<TRPCCatalog extends ZodSocketMessageCatalog
let ack;

try {
// FIXME: this only works if the message doesn't have genuine payload prop
if ("payload" in message) {
ack = await this.handleMessage({ type: eventName, ...message });
} else {
// Handle messages not sent by ZodMessageSender
const { version, ...payload } = message;
ack = await this.handleMessage({ type: eventName, version, payload });
}
const normalized = this.normalizeMessage(eventName, message);
ack = await this.handleMessage(normalized);
} catch (error) {
log.error("Error while handling message", {
error:
Expand Down
Loading