Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/pdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ def _exec_in_closure(self, source, globals, locals):
locals.update(pdb_eval["write_back"])
eval_result = pdb_eval["result"]
if eval_result is not None:
print(repr(eval_result))
self.message(repr(eval_result))

return True

Expand Down
28 changes: 28 additions & 0 deletions Lib/test/test_remote_pdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -1441,6 +1441,34 @@ def test_multi_line_commands(self):
self.assertIn("Function returned: 42", stdout)
self.assertEqual(process.returncode, 0)

def test_exec_in_closure_result_uses_pdb_stdout(self):
"""
Expression results executed via _exec_in_closure() should be written
to the debugger output stream (pdb stdout), not to sys.stdout.
"""
self._create_script()
process, client_file = self._connect_and_get_client_file()

with kill_on_error(process):
self._read_until_prompt(client_file)

self._send_command(client_file, "(lambda: 123)()")
messages = self._read_until_prompt(client_file)
result_msg = "".join(msg.get("message", "") for msg in messages)
self.assertIn("123", result_msg)

self._send_command(client_file, "sum(i for i in (1, 2, 3))")
messages = self._read_until_prompt(client_file)
result_msg = "".join(msg.get("message", "") for msg in messages)
self.assertIn("6", result_msg)

self._send_command(client_file, "c")
stdout, _ = process.communicate(timeout=SHORT_TIMEOUT)

self.assertNotIn("\n123\n", stdout)
self.assertNotIn("\n6\n", stdout)
self.assertEqual(process.returncode, 0)


def _supports_remote_attaching():
PROCESS_VM_READV_SUPPORTED = False
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed an issue in pdb where results of expressions evaluated via the closure execution path could be written to sys.stdout instead of the debugger output stream.
Loading