Remove error suppression operator (@) and add proper error handling #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling Replace error suppression operator (@) with explicit file existence and readability checks. Add new helper functions in include/file.inc (file_get_size, file_get_mtime, file_get_contents_if_exists) to safely handle file operations. This improves code reliability by catching actual errors rather than silencing them, and makes error handling explicit and testable throughout the codebase.
Add comprehensive documentation to the file header explaining the purpose of helper functions and their safety checks. Remove trailing stray braces that appear to be leftover code.
jordikroon
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
derickr
requested changes
Jan 13, 2026
| return false; | ||
| } | ||
|
|
||
| return file_get_contents($filename); |
Member
There was a problem hiding this comment.
There is a race condition here, if the file gets removed between the file_exists/is_readable, and the file_get_contents. This is quite possible, as the rsync process to put new data on the servers is not atomic. I would recommend keeping the @ here.
| // Open the note file for reading and get the data (12KB) | ||
| // ..if it exists | ||
| if (!file_exists($notes_file)) { | ||
| // if (!file_exists($notes_file) || !is_readable($notes_file)) { |
Member
There was a problem hiding this comment.
This introduces a parse error, as the { is now gone matching the } on line 106.
|
|
||
| // Open events CSV file, return on error | ||
| $fp = @fopen("backend/events.csv",'r'); | ||
| $fp = fopen($path,'r'); |
Member
There was a problem hiding this comment.
There are race conditions here too for similar reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some places the
@symbol was still used. This PR changes that behaviour with proper handling.Since those checks are always (correct me if I am wrong) for internal paths. A simple file_exists & is_readable check is sufficient. If not we could override the error handler instead.