Skip to content

Conversation

@tyrsson
Copy link
Member

@tyrsson tyrsson commented Jan 13, 2026

Signed-off-by: Joey Smith jsmith@webinertia.net

Signed-off-by: Joey Smith jsmith@webinertia.net

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC yes
QA yes
House Keeping no

Description

During a previous refactor handling of the php bool type was dropped for some reason when Adapter\Driver\Pdo\Statement::bindParametersFromContainer() was changed. This PR corrects that.

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson self-assigned this Jan 13, 2026
@tyrsson tyrsson added bug Something isn't working qa Improvements in quality assurance of the project Platform migration Changes related to platform migrations confirmed Has been confirmed by maintainers labels Jan 13, 2026
@tyrsson tyrsson added this to @phpdb Jan 13, 2026
@github-project-automation github-project-automation bot moved this to Todo in @phpdb Jan 13, 2026
@tyrsson tyrsson added this to the 0.6.0 milestone Jan 13, 2026
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Copy link
Collaborator

@simon-mundy simon-mundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-project-automation github-project-automation bot moved this from Todo to In Progress in @phpdb Jan 13, 2026
@tyrsson tyrsson merged commit e28a824 into php-db:0.6.x Jan 13, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @phpdb Jan 13, 2026
@tyrsson tyrsson deleted the fix-pdo-statement-bind-from-parameter-container branch January 13, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working confirmed Has been confirmed by maintainers Platform migration Changes related to platform migrations qa Improvements in quality assurance of the project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants