Backport: Improve CLI UX (#5223 #5227) #5228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, changing the application permissions from the CLI requires
specifying the whole final state of the permissions. So changing a
single field requires specifying all of them, otherwise they will be
replaced by default values.
Treat the parameters passed to `change-application-permissions` as
specifying changes instead of the target state.
The arguments now also have to be specified as JSON, because it is
necessary to be able to differentiate between no change, a `None` or an
empty list for some of the fields. Thus:
- an absence of a parameter means no change to the corresponding field
- a "null" means a `None` value (where applicable)
- a "[]" means an empty list.
Manually checked that the parameters are correctly interpreted.
CI will catch regressions.
- These changes should be backported to the latest `testnet` branch,
then
- be released in a new SDK,
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
afck
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
change-ownershipandchange-application-permissionssubcommands require the user to specify all the fields that are supposed to have non-default values, even if they don't change.Proposal
Treat missing arguments in CLI as a signal that the corresponding field should not be change. Use JSON for the value format, so that fields that should be set to
Nonecan be passed in asnull.Test Plan
Readme tests exercise the commands, manual checks have been run as well.
CI will catch regressions.
Release Plan
Links
main: