Repo: Update both version fields in package-lock.json
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
mgol
force-pushed
the
package-lock
branch
2 times, most recently
from
5f163cb to
d4c4406
Compare
Member
|
Please add |
mgol
commented
Jan 12, 2026
| module.exports = function( Release ) { | ||
|
|
||
| Release.define( { | ||
| _jsonFiles: [ "package.json", "package-lock.json", "bower.json" ], |
Member
Author
There was a problem hiding this comment.
I thought I first need to remove version from UI's bower.json but I do not - the version field was only added on tagged releases, on main it's not there.
`package-lock.json` versions 2 & 3 keep `version` in two fields - a top-level `version` one and a deep `packages[ "" ].version` one. Update both.
Member
Author
|
I did a test release of jQuery UI and I verified the release still works and the version is properly updated in the lockfile. |
timmywil
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package-lock.jsonversions 2 & 3 keepversionin two fields - a top-levelversionone and a deeppackages[ "" ].versionone. Update both.#117 needs to land first to fix CI.