Skip to content

HCK-14284: [Alter script]: Implement CREATE/DROP logic for schemas #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chulanovskyi-bs merged 6 commits into from
Jan 13, 2026
Merged

HCK-14284: [Alter script]: Implement CREATE/DROP logic for schemas #73

chulanovskyi-bs merged 6 commits into from
Jan 13, 2026

Conversation

@Nightlngale
Copy link
Contributor

@Nightlngale Nightlngale commented Jan 13, 2026 •
edited
Loading

Sub-taskHCK-14284 [DB2] Implement CREATE/DROP logic for schemas

Technical details

  • Added a new helper getUpdatedProperties to make it easier to support more changed properties in the future (for example, if we decide to add row_modification_tracking).
  • Refactored commentsHelper. I introduced new drop methods because the previous logic did not handle deletions. Reusing getCommentStatement with an empty description for delete operations would require adding checks in many existing places, so separating this logic makes the code safer and easier to maintain. Note: I also discovered that there are some general issues with comments in the plugin. As a result, this implementation might be revised further once those issues are addressed.

@Nightlngale Nightlngale self-assigned this Jan 13, 2026
@Nightlngale Nightlngale marked this pull request as ready for review January 13, 2026 11:12
AlikRakhmonov
AlikRakhmonov requested changes Jan 13, 2026
View reviewed changes
forward_engineering/alterScript/alterScriptHelpers/containerHelpers/commentsHelper.js
} = require('../../../ddlProvider/ddlHelpers/comment/commentHelper');
const { wrapInQuotes } = require('../../../utils/general');

const getModifiedCommentOnSchemaScriptDtos = ({ schemaName, compMod, isActivated }) => {
Copy link
Contributor

@AlikRakhmonov AlikRakhmonov Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Db2 doesn't support comments on schemas, or does it?

Copy link
Contributor Author

@Nightlngale Nightlngale Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports.
Screenshot 2026-01-13 at 12 41 51

@AlikRakhmonov AlikRakhmonov self-requested a review January 13, 2026 11:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chulanovskyi-bs chulanovskyi-bs enabled auto-merge (squash) January 13, 2026 13:04
@chulanovskyi-bs chulanovskyi-bs merged commit a00882c into develop Jan 13, 2026
8 checks passed
@chulanovskyi-bs chulanovskyi-bs deleted the HCK-14284 branch January 13, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlikRakhmonov AlikRakhmonov AlikRakhmonov approved these changes

@chulanovskyi-bs chulanovskyi-bs chulanovskyi-bs approved these changes

Assignees

@Nightlngale Nightlngale

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nightlngale @AlikRakhmonov @chulanovskyi-bs