-
-
Notifications
You must be signed in to change notification settings - Fork 3
Test Babel 8 compatibility #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Ping @NullVoxPopuli :) |
|
I don't know why CI isn't running on this one 🤔 and github isn't giving me the option to approve anything. I wonder if it's because you edited the Could you open a PR with just your first commit and I can get that merged and then you won't need approval anymore for CI? |
89e71e3 to
a009b55
Compare
|
Rebased, and CI is now running :) |
|
Yay CI is running! ... and failing 🫠 I am going to release the other change since that's compatible and this is just an internal testing change now. Maybe you have nerd sniped @NullVoxPopuli to get it over the line 😉 |
|
It's a ts compat issue -- like, our internal TS version is too old for file extensions. so, I think we should drop support for TS so old they don't believe in file extensions lol |
|
It's only for tests, I can also remove that option and ts-ignore the import. |
|
Oh well that didn't actually work, I'm debugging this locally |
872ad09 to
c83c0cb
Compare
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
Hey, Babel has an e2e test for Ember which makes me realize that this package cannot seamlessly upgrade to Babel 8.
This PR doesn't upgrade to Babel 8 yet, but it makes sure that when Babel 8 will be stable and you'll be ready for a major release you can simply update the dependency :)