compiler: fix buffering with multiple conditions #2826
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
buffering-multi-guards
branch
from
19bfb04 to
e5dc2af
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
=======================================
Coverage 78.98% 78.99%
=======================================
Files 248 248
Lines 50822 50833 +11
Branches 4391 4393 +2
=======================================
+ Hits 40141 40154 +13
Misses 9879 9879
+ Partials 802 800 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if c.scope.reads.get(self.f): | ||
| return c | ||
| return None | ||
| if c.scope.reads.get(self.f) and c.guards not in first_c: |
Contributor
There was a problem hiding this comment.
this looks very fragile at first glance
Contributor
Author
There was a problem hiding this comment.
How so? This just split the first read and last write per guard so that each different condition is respected
| if c.scope.writes.get(self.f): | ||
| return c | ||
| return None | ||
| if c.scope.writes.get(self.f) and c.guards not in last_c: |
mloubout
force-pushed
the
buffering-multi-guards
branch
from
e5dc2af to
93a78f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test in corresponding pro PR