WIP: feature: update function to use admin server with headers #616

Anmol1696 · 2026-01-16T12:22:28Z

No description provided.

Copilot

Pull request overview

This PR updates the send-email-link Knative function to support header-based routing for GraphQL requests to an admin server with API_IS_PUBLIC=false. The changes enable multi-tenant GraphQL access using custom headers (X-Database-Id, X-Meta-Schema, X-Api-Name, X-Schemata) instead of relying on hostname-based routing.

Changes:

Enhanced createGraphQLClient function to support additional header-based routing options for internal admin server communication
Updated Docker Compose configuration to use the new admin server setup with API_IS_PUBLIC=false
Replaced outdated PostgreSQL image with newer version (ghcr.io/constructive-io/docker/postgres-plus:17)
Removed simple-email function references from documentation and Docker Compose in favor of send-email-link

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`jobs/README.md`	Updated documentation to reflect `send-email-link` function usage with admin server header-based routing, removed `simple-email` references
`functions/send-email-link/src/index.ts`	Refactored `createGraphQLClient` to accept an options object with header-based routing parameters (databaseId, useMetaSchema, apiName, schemata)
`docker-compose.yml`	Updated PostgreSQL image from `pyramation/pgvector:13.3-alpine` to `ghcr.io/constructive-io/docker/postgres-plus:17`
`docker-compose.jobs.yml`	Renamed service from `constructive-server` to `constructive-admin-server`, added `API_IS_PUBLIC=false`, removed `simple-email` service references

Comments suppressed due to low confidence (1)

jobs/README.md:1

Corrected malformed heading. There's an extra 'n' character before the '#' symbol.

n# Jobs (Knative)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jobs/README.md

functions/send-email-link/src/index.ts

docker-compose.jobs.yml

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (1)

jobs/README.md:2

The line marker '----' (line 0 in diff) should be '---' (three hyphens) to match standard Markdown horizontal rule syntax used elsewhere in the document.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphql/server/src/middleware/api.ts

Copilot · 2026-01-16T17:16:51Z

functions/send-email-link/src/index.ts

  const hostHeader = process.env[envName];
  if (hostHeader) {
-    headers.host = hostHeader;
+    headers.Host = hostHeader;


HTTP header names should be lowercase when setting them programmatically. The graphql-request library expects lowercase header names. Change 'Host' to 'host' to ensure proper header transmission.

Suggested change

headers.Host = hostHeader;

headers.host = hostHeader;

Copilot · 2026-01-16T17:16:51Z

jobs/README.md

 ```

---
+### Enqueue email_verification job


The line marker '----' (line 0 in diff) should be '---' (three hyphens) to match standard Markdown horizontal rule syntax used elsewhere in the document.

Copilot · 2026-01-16T17:16:51Z

jobs/DEVELOPMENT_JOBS.md

+        'sender_id',    '$SENDER_ID'
      )::json
    );
  "


The line marker '----' (line 0 in diff) should be '---' (three hyphens) to match standard Markdown horizontal rule syntax used elsewhere in the document.

Copilot · 2026-01-16T17:16:51Z

graphql/server/src/middleware/api.ts

+        apiExtensions: {
          nodes: schemata
            .split(',')
            .map((schema) => schema.trim())
            .map((schemaName) => ({ schemaName })),
        },
-        schemaNames: { nodes: [] as Array<{ schemaName: string }> },
+        schemasByApiSchemaApiIdAndSchemaId: { nodes: [] as Array<{ schemaName: string }> },


The renamed field structure (apiExtensions and schemasByApiSchemaApiIdAndSchemaId) for hardcoded schemata routing lacks test coverage. Consider adding tests to verify the restructured data format works correctly with transformServiceToApi.

Copilot · 2026-01-16T17:16:51Z

graphql/server/src/middleware/api.ts

+        apiExtensions: {
          nodes: schemata.map((schemaName: string) => ({ schemaName })),
        },
-        schemaNames: { nodes: [] as Array<{ schemaName: string }> },
+        schemasByApiSchemaApiIdAndSchemaId: { nodes: [] as Array<{ schemaName: string }> },


The renamed field structure for meta schema routing lacks test coverage. Consider adding tests to verify this data structure works correctly with transformServiceToApi.

Copilot · 2026-01-16T17:16:52Z

functions/send-email-link/src/index.ts

+// TODO: Consider moving this to @constructive-io/knative-job-fn as a shared
+// utility so all job functions can create GraphQL clients with consistent
+// header-based routing without duplicating this logic.


This TODO comment identifies important refactoring work to share GraphQL client creation logic across job functions. Consider creating a tracking issue or documenting this technical debt in a more visible location to ensure it's addressed before this PR is finalized.

Copilot · 2026-01-16T17:16:52Z

functions/send-email-link/src/index.ts

+  // Header-based routing for internal cluster services (API_IS_PUBLIC=false)
+  if (options.databaseId) {
+    headers['X-Database-Id'] = options.databaseId;
+  }
+  if (options.useMetaSchema) {
+    headers['X-Meta-Schema'] = 'true';
+  }
+  if (options.apiName) {
+    headers['X-Api-Name'] = options.apiName;
+  }
+  if (options.schemata) {
+    headers['X-Schemata'] = options.schemata;
  }


The new header-based routing logic with multiple conditional header additions lacks test coverage. Consider adding unit tests to verify correct header construction for different option combinations.

Copilot · 2026-01-16T17:16:52Z

docker-compose.jobs.yml

+      # Point to admin server (uses X-Api-Name header routing when API_IS_PUBLIC=false)
+      GRAPHQL_URL: "http://constructive-admin-server:3000/graphql"
+      META_GRAPHQL_URL: "http://constructive-admin-server:3000/graphql"
+      # API name for header-based routing (X-Api-Name header) - kept for future use


The comment states 'kept for future use' but GRAPHQL_API_NAME is set to 'private'. This is confusing - either the variable is currently used (in which case update the comment) or it's not needed yet (in which case consider removing it until actually required).

Suggested change

# API name for header-based routing (X-Api-Name header) - kept for future use

# API name for header-based routing (X-Api-Name header), e.g. when API_IS_PUBLIC=false

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

update function to use admin server with headers

9a7c865

Anmol1696 requested a review from Copilot January 16, 2026 12:22

Copilot started reviewing on behalf of Anmol1696 January 16, 2026 12:26 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

jobs/README.md Show resolved Hide resolved

functions/send-email-link/src/index.ts Show resolved Hide resolved

docker-compose.jobs.yml Outdated Show resolved Hide resolved

Anmol1696 added 2 commits January 17, 2026 00:01

get functions working with private domain lookup

5accefe

let pgpm env be used, no need for graphql server to reset them

c308903

Anmol1696 requested a review from Copilot January 16, 2026 17:13

Copilot started reviewing on behalf of Anmol1696 January 16, 2026 17:14 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Anmol1696 and others added 3 commits January 16, 2026 21:28

Update graphql/server/src/middleware/api.ts

cccb039

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

try to fiddle with docker compose settings for jobs

8d2ca18

handle localhost properly, dont add subdomain to link

b19ea04

	# API name for header-based routing (X-Api-Name header) - kept for future use
	# API name for header-based routing (X-Api-Name header), e.g. when API_IS_PUBLIC=false

WIP: feature: update function to use admin server with headers #616

Are you sure you want to change the base?

WIP: feature: update function to use admin server with headers #616

Uh oh!

Conversation

Anmol1696 commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants