fix(stacked): Fix stacked area chart drawing on zero value #21468
+107
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR fixes a bug where stacked area charts with
stackStrategy: 'samesign'incorrectly draw an area for data points with a value of 0 by strictly excluding 0 from the stacking logic.Fixed issues
Details
Before: What was the problem?
When
stackStrategyis set to'samesign', the previous implementation treated0as a positive value (using a>= 0check). This caused zero-value points to be stacked on top of the previous series instead of being treated independently. As a result, the chart would render a visual area for the zero value, which is incorrect behavior for a stacked area chart.After: How does it behave after the fixing?
The stacking logic in
src/processor/dataStack.tshas been updated to strictly check for positive (> 0) or negative (< 0) values when usingsamesign. Zero values are no longer considered part of the stack group. This ensures that no area is drawn for 0 values, providing the correct visual representation.Validation:
test/ut/spec/processor/dataStack.test.tsto verify that 0 values result inNaNforstackedOverDimension.test/issue-21467.htmlhas been added for visual verification.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information